Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-sidebar does not respect "Hide sidebar" during tab-browsing #3

Closed
ralf3u opened this issue Mar 17, 2022 · 2 comments
Closed

auto-sidebar does not respect "Hide sidebar" during tab-browsing #3

ralf3u opened this issue Mar 17, 2022 · 2 comments

Comments

@ralf3u
Copy link

ralf3u commented Mar 17, 2022

condition

  • for txt-documents: the sidebar does not appear
  • for html-documents: the sidebar does appear

issue a)
steps to reproduce
1: put a html-document in focus
2: press shortcut "Hide sidebar" (result: there is no sidebar any more)
3: put a txt-document in focus
4: put back a html-document in focus
result: the sidebar is completely empty
expectation: there should be no sidebar

possible solution
I don't know how to program lua-scripts, but maybe a separate lua-script for the memory could be interesting, to remember if sidebar is disabled.





REMARK
if the issue above was solved, it could be that the next two following issues will not appear any more

issue b)
steps to reproduce
1: put a html-document in focus
2: press shortcut "Hide sidebar" (result: there is no sidebar any more)
3: put a txt-document in focus
4: put back a html-document in focus
result: the sidebar is completely empty, and the shortcut "Hide sidebar" need to be pressed 3x to let appear again the sidebar
expectation: there should be no sidebar, and by pressing 1x the shortcut "Hide sidebar", the sidebar should appear

issue c)
steps to reproduce
1: put a html-document in focus
2: press shortcut "Hide sidebar" (result: there is no sidebar any more)
3: close Geany
4: reopen Geany
result: the sidebar is completely empty
expectation: there should be no sidebar, and by pressing 1x the shortcut "Hide sidebar", the sidebar should appear

@ralf3u
Copy link
Author

ralf3u commented Feb 14, 2023

It seems to be that I did a mistake in the title of the report and in the report. The shortcut name is not Hide sidebar but Toggle sidebar.

@xiota
Copy link
Owner

xiota commented Feb 27, 2023

Fixed in 615c0c4. Requires using lua implementation of "toggle sidebar" to create state file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants