-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shortcut to toggle between editor and sidebar #4
Comments
I open a new issue for that: geany/geany#2914 I just put the thumbs-up-symbol for that issue number 2914, because a shortcut to toggle between editor and sidebar would be really great. I don't know which impact the thumbs-up-symbol has on the development timeline of an issue. But maybe it is better to have one thumbs-up-symbol than to have no thumbs-up-symbol. |
@ralf3u I agree a toggle is more convenient than separate shortcuts. That's why I'm willing to look into it if it's not accepted into the main editor. |
I already tried in the shortcut editor of Geany to give the two actions the same shortcut. But Geany refused. |
@ralf3u I just added a keybinding to toggle between the preview pane and the editor. It's in 771c581. I will update the PPA. If anything other than the editor is in focus, the keybinding will focus the editor. If the editor is in focus, the keybinding will focus the sidebar and switch tabs to the preview pane. By default, there is no key combination set for the toggle. The setting is in preferences. You should find it near the end of the keybinding list under the heading "Preview". |
I don't know what to say. I'm speechless. It is just simply amazing!! |
If I press the shortcut toggle editor/sidebar, then the tab-title "Preview" seems to be in focus. There are no signs for that but if I do both tests below, both tests are negative. The goal should be: Not the tab-title "Preview" should be in focus, but the content of the Preview-tab. control tests with a very long html-document, and with at least two tabs in the sidebar: In the end it should work exactly like the editor: |
I'll update the PPA. |
Something does not work properly: The content of the Preview-tab is completely empty for html-documents. |
Please try resetting the config and css files. If it still doesn't work, please provide more info. HTML documents with and without |
I did an update. I deleted the config-file of preview and I deleted the config-file of xitweaks, and I deleted all css-files of preview, so I don't need to reload them. And I deleted geany.css. Then I restarted Geany. With or without DOCTYPE, unsaved or saved: The content of the Preview-tab is completely empty for html-documents. Content of the Preview-tab of preview.conf: "Unable to process type: Conf, UTF-8." If I right-click in the Preview-tab, then the context menu appears. If I choose "Reload", then the html-document appears. I have to do that every time I restart Geany. |
Please show the contents of a short HTML document that has this problem. |
When I restart Geany, then there is in the light theme in the Preview-tab for about 2 seconds "Loading." And then there is nothing. |
That file works on my computer. Do you have any css files with the same background and foreground color? What about |
As mentioned before, I deleted geany.css. New try:
Do the same steps on your computer, to see if the same problem exists on your computer. Maybe it is because of pandoc.css, that is created automatically when Geany is restarted? For txt-documents: For html-documents: What I think |
Is this a problem.only when restarting Geany? Do HTML files opened after Geany is already started load? What about if you switch documents that are already opened? |
Not only when restarting Geany but also when Geany is open. Nothing is shown in the Preview of html-documents.
Nothing is shown in the Preview of html-documents.
Nothing is shown in the Preview of all html-documents. If I right-click in the Preview-tab, then the context menu appears. If I choose "Reload", then the html-document appears in the preview-tab. Did you do the following steps?
Then reopen Geany. Do you see something in the Preview of html-documents? |
Same problem with the old computer. Nothing is shown in the Preview of all html-documents. |
On the old computer, the package I unloaded all plugins except Preview. Then deleted What happens when you open a markdown document? (Create a file with some text and an |
Yes, it is installed, because if I do
I created a document test.md. Nothing is shown in the Preview-tab. If I right-click in the Preview-tab, then the context menu appears. If I choose "Reload", then test.md appears in the preview-tab. So, same problem like html-documents. new issue
So, if you did exactly the same like me, but we both have different results, maybe it is because you use 21.10 and I use 21.04? |
I don't have 21.04 installed anymore, but do have one with 20.04. I just tested it, and it works fine.
So there is some problem with both markdown and html documents? Please try the following:
If that does not help, what happens when you enable the following options in
In
Then you can install old ones to find one that works. Please let me know the file name of the newest one that works as expected. The command to install from
|
What I did:
I restarted Geany. Same problem like before. Then I did:
Then in Edit, Plugin Preferences, in Preview I clicked on Reload, Apply and OK. As I mentioned before:
Should I continue your description of #4 (comment)? |
You don't have to if you don't want to. It would help me to locate which version of the plugin potentially introduced a change that could be causing your problem. The info you've provided is helpful though, so I'll see if I can find anything.
|
In /var/cache/apt/archives |
It was this version, where Preview started not to work: #4 (comment) |
Thanks for trying. Your system must be configured to clear the cache. |
So, maybe it is because of the processor. The old computer is using a Celeron N3060 and the new computer is using a Pentium N5000. |
Which issue is that for? For slower computer, I would just expect it to take longer to display, rather than not display at all. There are timing options in Looking at my commit logs, I did change from using C strings to C++ std::strings. The advantage of C++ is better memory management. The disadvantage is it can be slower in some cases. I don't understand why it would work on one computer, but not another though. Would you mind downloading and testing Big-Fish.fountain. If the link doesn't work, you can get the file from fountain.io. The link should be on the lower-right. |
Big-Fish.fountain works perfect in the Preview. To the version when Preview started to make problems: It was the version, where pandoc.css was created in the preview-file automatically after restarting Geany. |
|
It was this version, where Preview started not to work and where pandoc.css was created in the preview-file automatically after restarting Geany: #4 (comment) |
In case you are interested: Because I will not use Geany for coding for the next weeks, you can offer every day a new version with small changes to localize where the problem is. I will give you every day feedback. |
Good to know I can update the PPA without disrupting anything. I looked over the code and don't see anything that would cause problems. I just tried the packages with Ubuntu 21.04, and it works as expected. So working on my end with 20.04, 21.04, and 21.10. Have you tried double clicking in the preview pane to see if there is some invisible text? |
@ralf3u I've pushed a minor update to the PPA. I don't expect it to fix the html/markdown problem though. Would you please open it as a new issue? |
I opened yesterday issue number 9 for that. |
Please open the issue at xiota/geany-tweaks |
It seems to be that xi/tweaks will be split in two plugins. So until there is only one plugin, would it be not better to let issue number 10 open? I tested now the shortcut toggle editor/sidebar. It works perfect. I use as shortcut F2 for toggle editor/sidebar. Just for interest: Which shortcut are you using? |
I would prefer it be moved to xiota/geany-tweaks/. After you do that, I will remove it from here, which is a different plugin. For naming, I'm thinking of "Tweaks-UI" for the plugin that will be submitted to geany-plugins. The other plugin will have the sidebar focus highlighting and menu-hiding. Basically keeping it because you use the focus highlighting and so you won't have to load yet another plugin just for menu hiding. Otherwise, I'd probably abandon the focus highlighting because I haven't been able to get it to work properly.
F2 is usually assigned to rename in file managers, so I don't want to get confused. Some shortcuts I'm using...
|
The text was updated successfully, but these errors were encountered: