os_types.h: Properly define types on macOS #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For more recent macOS builds, <sys/types.h> is not enought to correctly define aliased types. Adding <stdint.h> to include list fixes the issue, and makes building other libraries (i.e. vorbis) for macOS again. Signed-off-by: Francesco Giancane <francescogiancane8@gmail.com>
sezero
pushed a commit
to sezero/ogg
that referenced
this pull request
Jun 20, 2021
For more recent macOS builds, <sys/types.h> is not enought to correctly define aliased types. Adding <stdint.h> to include list fixes the issue, and makes building other libraries (i.e. vorbis) for macOS again. Signed-off-by: Francesco Giancane <francescogiancane8@gmail.com> xiph#73
sezero
pushed a commit
to sezero/ogg
that referenced
this pull request
Nov 12, 2021
For more recent macOS builds, <sys/types.h> is not enought to correctly define aliased types. Adding <stdint.h> to include list fixes the issue, and makes building other libraries (i.e. vorbis) for macOS again. Signed-off-by: Francesco Giancane <francescogiancane8@gmail.com> xiph#73
sezero
pushed a commit
to sezero/ogg
that referenced
this pull request
Oct 12, 2022
For more recent macOS builds, <sys/types.h> is not enought to correctly define aliased types. Adding <stdint.h> to include list fixes the issue, and makes building other libraries (i.e. vorbis) for macOS again. Signed-off-by: Francesco Giancane <francescogiancane8@gmail.com> xiph#73
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I was trying to build
oggvorbisflacopusandsndfilelibraries for macOS. Unfortunately, with more recent builds of the macOS operating systems, it seemed that some includes were missing.Digging deeper into the problem, I found that actually the culprit was
os_types.h, not including<stdint.h>.Adding the include fixed the issue.
ogg was built using
cmakeon a Big Sur macOS and latest XCode tools.