Skip to content

Commit

Permalink
Ogg Opus draft: Address chair review comments.
Browse files Browse the repository at this point in the history
1. Removed an inappropriate normative MAY.
2. Gave an explicit range of sample rates deemed to be "non-crazy".
3. Give explicit guidance on packet sizes that SHOULD and MAY be rejected.
  • Loading branch information
Timothy B. Terriberry committed Mar 13, 2015
1 parent 6814b2c commit 36e0445
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions doc/draft-ietf-codec-oggopus.xml
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ Each page is associated with a particular logical stream and contains a capture
stream, to aid seeking.
A single page can contain up to 65,025 octets of packet data from up to 255
different packets.
Packets MAY be split arbitrarily across pages, and continued from one page to
Packets can be split arbitrarily across pages, and continued from one page to
the next (allowing packets much larger than would fit on a single page).
Each page contains 'lacing values' that indicate how the data is partitioned
into packets, allowing a demuxer to recover the packet boundaries without
Expand Down Expand Up @@ -667,6 +667,10 @@ Encoders SHOULD write the actual input sample rate or zero, but decoder
implementations which do something with this field SHOULD take care to behave
sanely if given crazy values (e.g., do not actually upsample the output to
10 MHz if requested).
Input sample rates between 8 kHz and 192 kHz (inclusive) SHOULD be
supported.
Rates outside this range MAY be ignored by falling back to the default rate of
48 kHz instead.
<vspace blankLines="1"/>
</t>
<t><spanx style="strong">Output Gain</spanx> (16 bits, signed, little
Expand Down Expand Up @@ -1262,10 +1266,10 @@ Encoders SHOULD use no more padding than is necessary to make a variable
bitrate (VBR) stream constant bitrate (CBR).
Decoders SHOULD avoid attempting to allocate excessive amounts of memory when
presented with a very large packet.
Decoders SHOULD reject packets larger than 60&nbsp;kB per channel, and display
a warning message, and MAY reject packets larger than 7.5&nbsp;kB per channel.
The presence of an extremely large packet in the stream could indicate a
memory exhaustion attack or stream corruption.
Decoders SHOULD reject a packet that is too large to process, and display a
warning message.
</t>
<t>
In an Ogg Opus stream, the largest possible valid packet that does not use
Expand Down

0 comments on commit 36e0445

Please sign in to comment.