Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom modes does not work with 1.3.1 anymore #172

Closed
hoene opened this issue Mar 28, 2020 · 7 comments
Closed

Custom modes does not work with 1.3.1 anymore #172

hoene opened this issue Mar 28, 2020 · 7 comments

Comments

@hoene
Copy link

hoene commented Mar 28, 2020

We are testing Soundjack with Opus 1.3.1. Soundjack is used Opus custom modes (2^n).
Custom modes work with version 1.1.3 and 1.2.1. However, they crash with Opus 1.3.1.
@gmaxwell
Copy link
Contributor

Can you bisect to figure out which change broke it?

@hoene
Copy link
Author

hoene commented Mar 29, 2020 •
edited

Yes, I will do it will the command
./opus_custom_demo 48000 1 128 1000 test.sw out.sw

@hoene
Copy link
Author

hoene commented Mar 29, 2020 

# good: [ea8b26ff85fe143428cef3222b04249e80ef13d2] Fix comma that should have been a semicolon
git bisect good ea8b26ff85fe143428cef3222b04249e80ef13d2
# first bad commit: [2c0061c19bad73f49cd3f47eea440fd7799dbd90] Enable hardening by default

@hoene
Copy link
Author

hoene commented Mar 29, 2020

Indeed, if I switch off hardening, it even works with the latest master.

./configure --enable-custom-modes --disable-hardening

@jmvalin
Copy link
Member

jmvalin commented Mar 29, 2020

Thanks for bisecting. Should be simple to fix.

@hoene hoene mentioned this issue Apr 1, 2020
Closed
doloopuntil pushed a commit to doloopuntil/jamulus that referenced this issue Apr 9, 2020
Fix xiph/opus#172
80473bf 
CELT codec state validation fails when ENABLE_HARDENING compiled flag is used, due to mismatching expectation on maximum number of frequency bands.
doloopuntil pushed a commit to doloopuntil/jamulus that referenced this issue Apr 10, 2020
Fix celt decoder assertion when using OPUS_CUSTOM
eb6c2ca 
When using OPUS_CUSTOM, `CELTDecoder->end` can be larger than 21.
Assert against 25 instead in OPUS_CUSTOM builds.
See xiph/opus#172.
doloopuntil pushed a commit to doloopuntil/jamulus that referenced this issue Apr 10, 2020
Fix celt decoder assertion when using OPUS_CUSTOM
78c1f2c 
When using OPUS_CUSTOM, `CELTDecoder->end` can be larger than 21.
Assert against 25 instead in OPUS_CUSTOM builds.
See xiph/opus#172.
doloopuntil pushed a commit to doloopuntil/jamulus that referenced this issue Apr 10, 2020
Fix celt decoder assertion when using OPUS_CUSTOM
ad3a724 
When using OPUS_CUSTOM, `CELTDecoder->end` can be larger than 21.
Assert against 25 instead in OPUS_CUSTOM builds.
See xiph/opus#172.
doloopuntil pushed a commit to doloopuntil/jamulus that referenced this issue Apr 10, 2020
Fix celt decoder assertion when using OPUS_CUSTOM
1c7fa98 
When using OPUS_CUSTOM, `CELTDecoder->end` can be larger than 21.
Assert against 25 instead in OPUS_CUSTOM builds.
See xiph/opus#172.
doloopuntil pushed a commit to doloopuntil/jamulus that referenced this issue Apr 10, 2020
Fix celt decoder assertion when using OPUS_CUSTOM
d5493a4 
When using OPUS_CUSTOM, `CELTDecoder->end` can be larger than 21.
Assert against 25 instead in OPUS_CUSTOM builds.
See xiph/opus#172.
doloopuntil pushed a commit to doloopuntil/jamulus that referenced this issue Apr 11, 2020
Fix celt decoder assertion when using OPUS_CUSTOM
a47dc8d 
When using OPUS_CUSTOM, `CELTDecoder->end` can be larger than 21.
Assert against 25 instead in OPUS_CUSTOM builds.
See xiph/opus#172.
doloopuntil pushed a commit to doloopuntil/jamulus that referenced this issue Apr 11, 2020
Fix celt decoder assertion when using OPUS_CUSTOM
7492e9f 
When using OPUS_CUSTOM, `CELTDecoder->end` can be larger than 21.
Assert against 25 instead in OPUS_CUSTOM builds.
See xiph/opus#172.
doloopuntil pushed a commit to doloopuntil/jamulus that referenced this issue Apr 11, 2020
Fix celt decoder assertion when using OPUS_CUSTOM
6fa04b4 
When using OPUS_CUSTOM, `CELTDecoder->end` can be larger than 21.
Assert against 25 instead in OPUS_CUSTOM builds.
See xiph/opus#172.
@jmvalin
Copy link
Member

jmvalin commented Apr 13, 2020

Should now be fixed (merged the PR). Please re-open if that's not the case.

@jmvalin jmvalin closed this as completed Apr 13, 2020
@hoene
Copy link
Author

hoene commented Apr 13, 2020

Thanks @jmvalin

doloopuntil pushed a commit to doloopuntil/jamulus that referenced this issue Apr 13, 2020
Fix celt decoder assertion when using OPUS_CUSTOM
1f57900 
When using OPUS_CUSTOM, `CELTDecoder->end` can be larger than 21.
Assert against 25 instead in OPUS_CUSTOM builds.
See xiph/opus#172.
doloopuntil pushed a commit to doloopuntil/jamulus that referenced this issue Apr 14, 2020
Fix celt decoder assertion when using OPUS_CUSTOM
607afe8 
When using OPUS_CUSTOM, `CELTDecoder->end` can be larger than 21.
Assert against 25 instead in OPUS_CUSTOM builds.
See xiph/opus#172.
doloopuntil pushed a commit to doloopuntil/jamulus that referenced this issue Apr 15, 2020
Fix celt decoder assertion when using OPUS_CUSTOM
d27f387 
When using OPUS_CUSTOM, `CELTDecoder->end` can be larger than 21.
Assert against 25 instead in OPUS_CUSTOM builds.
See xiph/opus#172.
doloopuntil pushed a commit to doloopuntil/jamulus that referenced this issue Apr 16, 2020
Fix celt decoder assertion when using OPUS_CUSTOM
582f3e5 
When using OPUS_CUSTOM, `CELTDecoder->end` can be larger than 21.
Assert against 25 instead in OPUS_CUSTOM builds.
See xiph/opus#172.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jmvalin @gmaxwell @hoene