Silk makes use of Opus VAD #87
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustafullberg
force-pushed
the
use_opus_vad_in_silk
branch
from
29c1a41
to
bda4c0e
Compare
|
Updated the PR to fix some issues. |
gustafullberg
force-pushed
the
use_opus_vad_in_silk
branch
from
bda4c0e
to
dbc2736
Compare
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
May 16, 2018
Cherry-picked from xiph/opus#87 Change-Id: I328f08be0396597d83ef09b13624f2a236fe0263 Reviewed-on: https://chromium-review.googlesource.com/1060739 Reviewed-by: Henrik Andreasson <henrika@chromium.org> Commit-Queue: Felicia Lim <flim@chromium.org> Cr-Commit-Position: refs/heads/master@{#559123}
|
Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is an alternative solution to the problem described in PR #84 . It was created in response to Jean-Marc Valin's comment.
The PR makes Silk use the Opus VAD when available (float API enabled, complexity level high enough). When the Opus vad is not used the Silk VAD will be used instead.
Using the same VAD for Silk and Opus solves the issue with the "click sounds", described in PR #84, that are caused by PLC usage in the DTX region.
Behavior of complexity modes where the Opus VAD is not run is unchanged.