Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support minimum partitions types. #127

Closed
mbebenita opened this issue Mar 15, 2018 · 1 comment
Closed

Support minimum partitions types. #127

mbebenita opened this issue Mar 15, 2018 · 1 comment
Assignees
@ycho
Labels
conformance
Projects
MVP
Milestone
MVP

Comments

@mbebenita
Copy link
Collaborator

Do we want 128x128 from the start? Do this include 4:1 and 1:4 partitions? (use speed levels for this)
@mbebenita mbebenita created this issue from a note in MVP (To do) Mar 15, 2018
@mbebenita mbebenita removed this from To do in MVP Mar 15, 2018
@mbebenita mbebenita added this to the MVP milestone Mar 15, 2018
@mbebenita mbebenita added this to To do in MVP Mar 16, 2018
@mbebenita mbebenita moved this from To do to In progress in MVP Mar 16, 2018
ycho referenced this issue Mar 16, 2018
@ycho @tdaede
Enable partition : part 1, split down to 8x8 blocks
5ecf002 
This is part 1 of ongoing work of enabling partition encoding.
Every SuperBlock is partitioned down to 8x8 partitions,
where pre-existing RDO mode decision decides intra modes
(among three, DC_PRED, HORZ_PRED. VERT_PRED) for the 8x8 partition.

If input image size is not multiple of 8 pixels,
the coded image is padded to be multiple of 8 pixels in both width and height.

TEST: subset1 images.

cargo build --bin rav1e --release
rm test.ivf test_rec.y4m test_dec.y4m
./target/release/rav1e /home/yushin/sequences/subset1-y4m/125_-_Québec_-_Pont_de_Québec_de_nuit_-_Septembre_2009.y4m -o test.ivf  -r test_rec.y4m --quantizer 50
./aom_test/aomdec test.ivf -o test_dec.y4m -v
mpv --keep-open test_dec.y4m &
mpv --keep-open test_rec.y4m &

TODO:
1. Fix partition down to 4x4 blocks, which will include fixing
   has_chroma() function
2. RDO-based block size decision
This was referenced Mar 16, 2018
Merged
Merged
@ycho
Copy link
Collaborator

ycho commented Apr 3, 2018 •
edited

Change the title to "Support Minimum Partition Types", because Supporting all partition types is pointless unless we have RDO based block size decision available, which has not started yet and no due is set. By "Minimum Partition Types", I would define it as a set of two essential types, PARTITION_NONE and PARTITION_SPLIT.
"Support all partitions types" will be added as a new task but not as MVP item.

@ycho ycho changed the title Support all partitions types. Support minimum partitions types. Apr 3, 2018
@ycho ycho closed this as completed Apr 3, 2018
@ycho ycho mentioned this issue Apr 3, 2018
Open
@ycho ycho moved this from In progress to Done in MVP Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ycho ycho

Labels
conformance
Projects
No open projects
MVP
  
Done
Milestone
MVP
Development

No branches or pull requests
2 participants
@mbebenita @ycho