Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build the app #10

Closed
2 tasks
Xiphe opened this issue Apr 9, 2020 · 2 comments
Closed
2 tasks

Build the app #10

Xiphe opened this issue Apr 9, 2020 · 2 comments
Labels
type: 👷internal Improvement to workflows, internal complexity, maintainability
Milestone
Alpha

Comments

@Xiphe
Copy link
Owner

Xiphe commented Apr 9, 2020

requires:

  • build script that works at least locally
  • upload build artifact to github releases
@Xiphe Xiphe added this to the Alpha milestone Apr 9, 2020
@Xiphe Xiphe added the type: 👷internal Improvement to workflows, internal complexity, maintainability label Apr 9, 2020
Xiphe added a commit that referenced this issue Apr 17, 2020
@Xiphe
feat: build that thing
6c64bbf 
schagga schagga

fix #11
ref #10
Xiphe added a commit that referenced this issue Apr 17, 2020
@Xiphe
perf: create webpack bundle of main bootstrap
411e1ed 
in order to not ship unused node_modules and remove fs reads

ref #10
Xiphe added a commit that referenced this issue Apr 17, 2020
@Xiphe
feat: add application icon
91454b3 
#besseralsnix

ref #10
@ghost
Copy link

ghost commented Apr 17, 2020 •
edited by Xiphe

alright, thanks for pointing me in the right direction on twitter. I was experimenting and don't know my way around too much.

Following you instructions I ran npm install and then npm start
resulted in the following error message.
If you want me to create a new issue for this, let me know.
Running node version v13.12.0

[start:electron] App threw an error during load
[start:electron] /Users/jd/dev/budgetbudget/main/index.ts:1
[start:electron] export { default } from './bootstrap';
[start:electron] ^^^^^^
[start:electron]
[start:electron] SyntaxError: Unexpected token 'export'
[start:electron]     at Module._compile (internal/modules/cjs/loader.js:896:18)
[start:electron]     at Module.m._compile (/Users/jd/dev/budgetbudget/node_modules/ts-node/src/index.ts:837:23)
[start:electron]     at Module._extensions..js (internal/modules/cjs/loader.js:986:10)
[start:electron]     at Object.require.extensions.<computed> [as .ts] (/Users/jd/dev/budgetbudget/node_modules/ts-node/src/index.ts:840:12)
[start:electron]     at Module.load (internal/modules/cjs/loader.js:816:32)
[start:electron]     at Module._load (internal/modules/cjs/loader.js:728:14)
[start:electron]     at Module._load (electron/js2c/asar.js:717:26)
[start:electron]     at Function.Module._load (electron/js2c/asar.js:717:26)
[start:electron]     at Module.require (internal/modules/cjs/loader.js:853:19)
[start:electron]     at require (internal/modules/cjs/helpers.js:74:18)

@Xiphe Xiphe mentioned this issue Apr 17, 2020
Closed
@Xiphe
Copy link
Owner Author

Xiphe commented Apr 17, 2020

would like to move the discussion to #19
this issue is about building the distributable MacOS App

Xiphe added a commit that referenced this issue Apr 19, 2020
@Xiphe
chore: notarize the app after signing
4b02aff 
ref #9
ref #10
@Xiphe Xiphe closed this as completed in a3090e7 Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: 👷internal Improvement to workflows, internal complexity, maintainability
Projects
None yet
Milestone
Alpha
Development

No branches or pull requests
1 participant
@Xiphe