Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contribution docs #19

Closed
Xiphe opened this issue Apr 17, 2020 · 6 comments
Closed

Contribution docs #19

Xiphe opened this issue Apr 17, 2020 · 6 comments

Comments

@Xiphe
Copy link
Owner

Xiphe commented Apr 17, 2020

For people that want to run the app from source locally or want to contribute there should be docs on how to setup the app and get it running.
@Xiphe
Copy link
Owner Author

Xiphe commented Apr 17, 2020

@pressqu pointed out the following:

#10 (comment)

@Xiphe Xiphe mentioned this issue Apr 17, 2020
Closed
2 tasks
@Xiphe
Copy link
Owner Author

Xiphe commented Apr 17, 2020

Currently trying to reproduce the issue.

@Xiphe
Copy link
Owner Author

Xiphe commented Apr 17, 2020

Managed to reproduce it on node 12.13.0 after i've thrown away node_modules and did a fresh install.

investigating

@ghost
Copy link

ghost commented Apr 17, 2020 •
edited by ghost

The issue persists on node 13.13. Threw out my node modules as well

Xiphe added a commit that referenced this issue Apr 17, 2020
@Xiphe
fix(dev): compile to commonjs for dev-mode
8f51b21 
this has recently been removed in favour of esnext from main tsconfig
in order to better support tree-shaing when being build with webpack

but this caused node-ts to not be able to process the esnext imports

ref #19
@Xiphe
Copy link
Owner Author

Xiphe commented Apr 17, 2020 •
edited

@pressqu should be fixed on master now.
I accidentally introduced it in 411e1ed when i focussed on the tree-shaking for production build.

@ghost
Copy link

ghost commented Apr 17, 2020

@Xiphe Got it running. Thanks

@Xiphe Xiphe closed this as completed in 1ca3c7b Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Xiphe