Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to exclude reserved transactions #78

Closed
leo-benz opened this issue Feb 12, 2021 · 5 comments
Closed

Add option to exclude reserved transactions #78

leo-benz opened this issue Feb 12, 2021 · 5 comments
Labels
Milestone

Comments

@leo-benz
Copy link
Contributor

Feature Request
As a user I would like to have a setting to ignore reserved transactions (vorgemerkte Umsätze).

Use-Case
I have a monthly mortgage payment that is deducted via SEPA Lastschrift and is shown as reserved for a few days before the transaction. I always split this payment in money money into interest and repayment of the loan and assign the splits to different categories. The split in money money is only possible after the transactions has cleared. Therefore it is uncategorised while it is a reserved transaction. In the days while it has not cleared BudgetBudget shows the month as over budgeted due to the uncategorised transaction even tough I have budgeted for the interest and repayment in the respective categories. Therefore I would like BudgetBudget to ignore the reserved transaction.

Since there are probably different opinions on this I would propose to add a user setting so that this behaviour is customisable.

@Xiphe
Copy link
Owner

Xiphe commented Feb 12, 2021

I understand the problem and agree that this would be a nice setting to have.

If we get the information from MM, I'll happily implement this

@Xiphe Xiphe added this to the Stable milestone Feb 12, 2021
@Xiphe Xiphe added the type: 🤩feature User facing feature label Feb 12, 2021
@leo-benz
Copy link
Contributor Author

I just checked and the exported plist contains the boolean key
<key>booked</key> <false/>
So the required data should be available.

@leo-benz
Copy link
Contributor Author

I started implementing this myself and will provide a PR soon.

@Xiphe
Copy link
Owner

Xiphe commented Feb 13, 2021

awesome!

leo-benz added a commit to leo-benz/budgetbudget that referenced this issue Feb 13, 2021
leo-benz added a commit to leo-benz/budgetbudget that referenced this issue Feb 15, 2021
leo-benz added a commit to leo-benz/budgetbudget that referenced this issue Feb 15, 2021
@Xiphe Xiphe closed this as completed in 5436c41 Feb 15, 2021
@github-actions
Copy link

🎉 This issue has been resolved in version 1.0.0-beta.15 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants