Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some observations on the docker implementation #330

Closed
gctwnl opened this issue Apr 17, 2023 · 2 comments
Closed

Some observations on the docker implementation #330

gctwnl opened this issue Apr 17, 2023 · 2 comments

Comments

@gctwnl
Copy link

gctwnl commented Apr 17, 2023

Request

Security improvements.

  1. The UID for the DSMR nginx is hardcoded 100. That means the process runs as a user which may clash with another (it usurps the permissions of that user, e.g. _apt on ubuntu). While it is containerised, it is less secure than running as some separate guaranteed non-privileged user. Having the container work well with --user (or docker compose user: setting) would be an improvement.
  2. The nginx config contains both conf.d and http.d of which only the latter is used
  3. The nginx config accepts TLS v1.1. Time to be more strict.

Additional information

No response

@xirixiz
Copy link
Owner

xirixiz commented Apr 18, 2023

Hi, thanks for your remarks!

  1. The user/uid used for DSMR is by default app/803. This default can be modified: https://github.com/xirixiz/dsmr-reader-docker#settings
  2. Correct. This changed in the last release and will be fixed next release.
  3. I agree and will fix it in the next release.

@xirixiz
Copy link
Owner

xirixiz commented Apr 18, 2023

Updated the main branch for 2 and 3.

@xirixiz xirixiz closed this as completed Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants