Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to disable nginx access logs #305

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Add option to disable nginx access logs #305

merged 1 commit into from
Dec 9, 2022

Conversation

rogierlommers
Copy link
Contributor

No description provided.

@rogierlommers rogierlommers mentioned this pull request Dec 8, 2022
Closed
@rogierlommers
Copy link
Contributor Author

By the way, can you give me instruction how you normally test changes?

@xirixiz
Copy link
Owner

xirixiz commented Dec 8, 2022

DSMR Reader Docker is here for a while now. Back then, I mainly had a background in operations and mainly bash scripting :). I guess I don't need to explain I found testing unnecessary.

Anyway, was thinking to spend some time in 2023 to rewrite things in a TTD way and get rid of all the bash things.

@rogierlommers
Copy link
Contributor Author

DSMR Reader Docker is here for a while now. Back then, I mainly had a background in operations and mainly bash scripting :). I guess I don't need to explain I found testing unnecessary.

Anyway, was thinking to spend some time in 2023 to rewrite things in a TTD way and get rid of all the bash things.

No problem, I was just thinking how I could easily test my changes locally.
Let me know if you need something more!

@xirixiz
Copy link
Owner

xirixiz commented Dec 8, 2022

When I merge something to the develop branch, a pipeline builds a new release with de development tag. That's how I personally validate a new baked image.

@xirixiz xirixiz merged commit b13aa3c into xirixiz:master Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rogierlommers @xirixiz