Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

如何针对 ECMAScript 规范创建一个拉取请求 #8626

Merged
merged 6 commits into from
May 25, 2021
Merged

如何针对 ECMAScript 规范创建一个拉取请求 #8626

merged 6 commits into from
May 25, 2021

Conversation

PassionPenguin
Copy link
Contributor

译文翻译完成，resolve #8612

@KimYangOfCat
Copy link
Contributor

@lsvih 校对认领

@lsvih
Copy link
Member

lsvih commented May 22, 2021

@KimYangOfCat 好的

KimYangOfCat
KimYangOfCat reviewed May 22, 2021
View reviewed changes
Copy link
Contributor

@KimYangOfCat KimYangOfCat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lsvih 校对完毕
@PassionPenguin 翻译很好，赞
想要一份转载授权，用以将译文发布于我的个人博客上：https://kimyang.cn/ ，我会留下详细的授权信息以及翻译计划信息，希望得到你的允许～

article/ECMA-TC39/How-to-make-a-Pull-Request-against-the-ECMAScript-specification.md Outdated Show resolved Hide resolved
article/ECMA-TC39/How-to-make-a-Pull-Request-against-the-ECMAScript-specification.md Outdated Show resolved Hide resolved
article/ECMA-TC39/How-to-make-a-Pull-Request-against-the-ECMAScript-specification.md Outdated Show resolved Hide resolved
@PassionPenguin
Copy link
Contributor Author

@lsvih 校对完毕
@PassionPenguin 翻译很好，赞
想要一份转载授权，用以将译文发布于我的个人博客上：https://kimyang.cn/ ，我会留下详细的授权信息以及翻译计划信息，希望得到你的允许～

可以的可以的~~~

@KimYangOfCat
Copy link
Contributor

可以的可以的~~~

感谢～

@Usualminds
Copy link
Contributor

@lsvih 校对认领

@lsvih
Copy link
Member

lsvih commented May 23, 2021

@Usualminds 好的~

Usualminds
Usualminds reviewed May 24, 2021
View reviewed changes
Copy link
Contributor

@Usualminds Usualminds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PassionPenguin 校对完成

article/ECMA-TC39/How-to-make-a-Pull-Request-against-the-ECMAScript-specification.md Outdated Show resolved Hide resolved
article/ECMA-TC39/How-to-make-a-Pull-Request-against-the-ECMAScript-specification.md Outdated Show resolved Hide resolved
article/ECMA-TC39/How-to-make-a-Pull-Request-against-the-ECMAScript-specification.md Outdated Show resolved Hide resolved
article/ECMA-TC39/How-to-make-a-Pull-Request-against-the-ECMAScript-specification.md Outdated Show resolved Hide resolved
article/ECMA-TC39/How-to-make-a-Pull-Request-against-the-ECMAScript-specification.md Outdated Show resolved Hide resolved
article/ECMA-TC39/How-to-make-a-Pull-Request-against-the-ECMAScript-specification.md Outdated Show resolved Hide resolved
article/ECMA-TC39/How-to-make-a-Pull-Request-against-the-ECMAScript-specification.md Outdated Show resolved Hide resolved
article/ECMA-TC39/How-to-make-a-Pull-Request-against-the-ECMAScript-specification.md Outdated Show resolved Hide resolved
article/ECMA-TC39/How-to-make-a-Pull-Request-against-the-ECMAScript-specification.md Outdated Show resolved Hide resolved
@Usualminds
Copy link
Contributor

@PassionPenguin 全局的拉去请求翻译为合并请求，是不是更通俗点，一个小建议

PassionPenguin and others added 2 commits May 24, 2021 07:58
@PassionPenguin @Usualminds @KimYangOfCat
Apply suggestions from code review
a9d7292 
Co-authored-by: Joe <me@qjidea.com>
Co-authored-by: Kim Yang <Kim.Yang.GH@outlook.com>
@PassionPenguin @Usualminds
Update article/ECMA-TC39/How-to-make-a-Pull-Request-against-the-ECMAS…
841b00b 
…cript-specification.md

Co-authored-by: Joe <me@qjidea.com>
kimberlyohq
kimberlyohq reviewed May 24, 2021
View reviewed changes
Copy link
Contributor

@kimberlyohq kimberlyohq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PassionPenguin 这里好像不小心打错了？🙈

article/ECMA-TC39/How-to-make-a-Pull-Request-against-the-ECMAScript-specification.md Outdated Show resolved Hide resolved
@PassionPenguin @kimberlyohq
Update article/ECMA-TC39/How-to-make-a-Pull-Request-against-the-ECMAS…
94a4b2a 
…cript-specification.md

Co-authored-by: Kimberly <60393696+kimberlyohq@users.noreply.github.com>
@PassionPenguin
Copy link
Contributor Author

@PassionPenguin 这里好像不小心打错了？🙈

感谢感谢（挠头挠头

@PassionPenguin
Copy link
Contributor Author

@PassionPenguin 全局的拉去请求翻译为合并请求，是不是更通俗点，一个小建议

噗哈哈哈主要是 GitHub 手机端是拉取请求（

@lsvih lsvih merged commit 43d9cc1 into xitu:master May 25, 2021
@PassionPenguin PassionPenguin deleted the translation/How-to-make-a-Pull-Request-against-the-ECMAScript-specification branch May 25, 2021 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Usualminds Usualminds Usualminds left review comments

@KimYangOfCat KimYangOfCat KimYangOfCat left review comments

@kimberlyohq kimberlyohq kimberlyohq left review comments

@lsvih lsvih lsvih approved these changes

Assignees
No one assigned
Labels
ECMA-TC39 前端 翻译完成
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

如何针对 ECMAScript 规范创建一个拉取请求
5 participants
@PassionPenguin @KimYangOfCat @lsvih @Usualminds @kimberlyohq