APIReference-Execution.md #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonirrings
requested changes
Aug 3, 2017
|
|
||
| <ul class="apiIndex"> | ||
| <li> | ||
| <a href="#execute"> | ||
| <pre>function execute</pre> | ||
| Executes a GraphQL request on the provided schema. | ||
| 对定义好的 schema 执行一个 GraphQL 请求。 |
There was a problem hiding this comment.
provided这个词能不能翻译成“给定”，或者“现有”？讨论讨论~~~
There was a problem hiding this comment.
翻译成”给定“吧。
对给定的 schema 执行一个 GraphQL 请求。
| @@ -46,13 +45,10 @@ type ExecutionResult = { | |||
| } | |||
| ``` | |||
|
|
|||
| Implements the "Evaluating requests" section of the GraphQL specification. | |||
| 上面的代码实现了 GraphQL 规范中评估请求“的部分。 | |||
There was a problem hiding this comment.
evaluate其实更多是“演算，求值”，譬如evaluate a function。对应中文一起讨论讨论。
There was a problem hiding this comment.
构建请求不适合，因为请求是在客户端构建，服务端处理来自客户端的请求，这里是服务端，直接翻译成 处理请求 如何?
|
|
||
| If the arguments to this function do not result in a legal execution context, | ||
| a GraphQLError will be thrown immediately explaining the invalid input. | ||
| 如果这个函数的参数导致产生了一个非法的执行上下文，那么马上就会有一个解释非法输入的 GraphQLError 被抛出。 |
There was a problem hiding this comment.
- “导致”和“产生”重复。
- 那么马上就会有一个 GraphQLError 被抛出，表示非法输入。
你看如何？
There was a problem hiding this comment.
- 如果这个函数的参数造成了一个非法的执行上下文
- 那么马上就会有一个 GraphQLError 被抛出，这个错误将会解释非法输入的具体信息。（引文前面的章节提到 GraphQLError 包含一些 location 和 info，这个地方这么翻译更清楚一点）
|
@jonirrings 麻烦看下修改意见，如果没问题的话，我就按照我的回复再提交一个修订版，如果有问题继续在对话框里面讨论。 |
|
@XatMassacrE 回复了，你瞅瞅 |
|
@jonirrings 感谢校对。 |
|
@sqrthree 按照校对意见修改完毕。 |
linhe0x0
reviewed
Aug 8, 2017
| @@ -46,13 +45,10 @@ type ExecutionResult = { | |||
| } | |||
| ``` | |||
|
|
|||
| Implements the "Evaluating requests" section of the GraphQL specification. | |||
| 上面的代码实现了 GraphQL 规范中”处理请求“的部分。 | |||
|
@sqrthree 改好啦 |
linhe0x0
approved these changes
Aug 9, 2017
|
@jonirrings 需要你来检查并 approve 一下。 |
jonirrings
approved these changes
Aug 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #14