Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor view model #171

Merged
merged 29 commits into from
Feb 25, 2020
Merged

refactor view model #171

merged 29 commits into from
Feb 25, 2020

Conversation

xizzhu
Copy link
Owner

@xizzhu xizzhu commented Feb 15, 2020

No description provided.

@xizzhu
Reorganized AndroidX dependencies
febce97
@xizzhu
Refactored reading progress to use AndroidX ViewModel and LifeCycle
45042ae
@xizzhu
Refactored settings activity to use AndroidX ViewModel and LifeCycle
a25a754
@xizzhu
Refactored Strong's numbers activity to use AndroidX ViewModel and Li…
9de5949 
…feCycle
@xizzhu
Refactored search activity to use AndroidX ViewModel and LifeCycle
e643bb4
@xizzhu
Refactored annotated verses activity to use AndroidX ViewModel and Li…
cd23db9 
…feCycle
@xizzhu
Refactored translations activity to use AndroidX ViewModel and LifeCycle
3364dec
@xizzhu
onBind() no longer passes viewHolder as a param
f6faa9f
@xizzhu
Removed unused code
43e5b80
@xizzhu
Refactored ReadingProgressViewModel to return a flow of ReadingProgre…
ec8f426 
…ssViewData
@xizzhu
Renamed viewData() to readingProgress()
91163d3
@xizzhu
Refactor StrongNumberListViewModel to return a flow of StrongNumberVi…
68205a5 
…ewData
@xizzhu
Added more unit test for StrongNumberViewModel
b9d87b5
@xizzhu
Refactored BaseAnnotatedVersesViewModel to return a flow of Annotated…
5276026 
…VersesViewData
@xizzhu
Refactored SearchViewModel to return a flow of SearchResult
2df6a77
@xizzhu
Fixed unit tests for SearchViewModel
ab5daca
@xizzhu
Refactored TranslationsViewModel to always return flows
6273350
@xizzhu
Refactored to directly use ReadingViewModel
056c9cf
@xizzhu
Refactored ReadingViewModel and presenters to inherit from AndroidX V…
355e643 
…iewModel
@xizzhu
Deleted obsoleted code
db5aa9e
@xizzhu
Simplified constructor of ViewPresenter
9094ad1
@xizzhu
Merged date formatting into BaseAnnotatedVersesPresenter
485c5e3
@xizzhu
Added more unit tests for BaseAnnotatedVersesPresenter
b3c7cff
@xizzhu
Added unit tests for viewFrom()
5ac0492
@xizzhu
Added unit tests for ReadingProgressPresenter
80493bb
@xizzhu
Added unit tests for StrongNumberListPresenter
101f3b0
@xizzhu
Added unit tests for SearchResultListPresenter
04ba74d
@xizzhu
Added unit tests for TranslationListPresenter
290219e
@xizzhu
Updated changelog
022ec15
@xizzhu xizzhu merged commit 90c4b7d into master Feb 25, 2020
@xizzhu xizzhu deleted the refactor-view-model branch February 25, 2020 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@xizzhu