Fix crash when linting an empty destructuring or import #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code is fairly useless, but it can come up e.g. while editing with an on the fly linter.
feross
added a commit
that referenced
this pull request
Feb 5, 2016
Fix crash when linting an empty destructuring or import
|
LGTM |
|
I'm surprised you can run |
|
@dcousens I'm using https://atom.io/packages/linter-js-standard, which seems to work reliably and isn't too disruptive, except for the exception report popups. Unless you meant something else? |
|
@sorear maybe I'm just too used to VIM running it in the main thread and causing a noticeable pause. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code is fairly useless, but it can come up e.g. while editing with an on the fly linter.
The test suite fails for me with nine instances of
AssertionError: Error should be a string or object.; there should be no new failures.