Skip to content

Commit

Permalink
TACO-199 - remove unneeded comments
Browse files Browse the repository at this point in the history
  • Loading branch information
codeman9 committed Aug 6, 2018
1 parent 918da86 commit 4ee5a36
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 19 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Tracing buildTracing(@NonNull String name, @NonNull String zipkinUrl, float samp
// puts trace IDs into logs
.currentTraceContext(MDCCurrentTraceContext.create())
.spanReporter(buildReporter(zipkinUrl))
.sampler(Sampler.create(samplingRate)) // TODO: Investigate BoundarySampler
.sampler(Sampler.create(samplingRate))
.build();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -141,22 +141,4 @@ public void testOutBoundAndInboundSpan() throws Exception {
byte[] bytes = Hex.decodeHex(responseHex.toCharArray());
assertEquals(expectedResponse, new String(bytes, "UTF-8"));
}

// // @Override
// @Test(expected = ComparisonFailure.class)
// public void redirect() throws Exception {
// throw new AssumptionViolatedException("client does not support redirect");
// }
//
// // @Override
// @Test(expected = ComparisonFailure.class)
// public void addsStatusCodeWhenNotOk() throws Exception {
// throw new AssumptionViolatedException("test is flaky");
// }
//
// // @Override
// @Test(expected = ComparisonFailure.class)
// public void httpPathTagExcludesQueryParams() throws Exception {
// throw new AssumptionViolatedException("test is flaky");
// }
}

0 comments on commit 4ee5a36

Please sign in to comment.