TACO-326-supreme removing the idle channel handler from the ClientCha… #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nnelInitializer so that we don't manually close the channel just because it is idling, we are trying to keep the client channels open so when we reuse the client we don't have to do the whole handshake over again to connect
khappucino
requested review from
pdex,
manimaul,
codeman9,
Rivukis,
nordjc and
jguamie
manimaul
approved these changes
Jun 7, 2018
manimaul
reviewed
Jun 7, 2018
| @@ -64,7 +63,6 @@ protected void initChannel(Channel channel) throws Exception { | |||
| } | |||
| channel | |||
| .pipeline() | |||
| .addLast("idle handler", new XioIdleDisconnectHandler(60, 60, 60)) | |||
There was a problem hiding this comment.
i think client is meant to be used not just as a proxy client... i wonder if the disconnect handler should be removed by the proxy client factory instead
There was a problem hiding this comment.
... or better yet a configurable timeout
There was a problem hiding this comment.
yeah making update, good idea
There was a problem hiding this comment.
I will add tests as well
…ting the base reference.conf to fill this in for us, next adding test to ClientChannelInitializerTest.java
manimaul
approved these changes
Jun 8, 2018
pdex
approved these changes
Jun 8, 2018
| private final Map<ChannelOption<Object>, Object> bootstrapOptions; | ||
| private final String name; | ||
| private final TlsConfig tls; | ||
| private final boolean messageLoggerEnabled; | ||
| private final InetSocketAddress local; | ||
| private final InetSocketAddress remote; | ||
| private final IdleTimeoutConfig idleTimeoutConfig; |
| @@ -163,6 +163,8 @@ xio { | |||
| remotePort = 0 | |||
| localIp = "" | |||
| localPort = 0 | |||
| idleTimeoutEnabled = false | |||
| idleTimeoutDuration = 0 | |||
There was a problem hiding this comment.
At some point we may want the type of incoming connection to determine if there’s no idle timeout. This is fine for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nnelInitializer so that we don't manually close the channel just because it is idling, we are trying to keep the client channels open so when we reuse the client we don't have to do the whole handshake over again to connect