starknet-core dependency serde_json arbitrary precision feature flag

[fracek]

The starknet-core crate has the serde_json arbitrary precision feature flag enabled.
This flag causes numbers to be encoded as the following object:

{"$serde_json::private::Number": "123.45"}

Any library that depends on starknet-core will then use this encoding for numbers.
Since AFAIK the crate is not using this specific feature I believe it makes sense to drop the feature flag.

[xJonathanLEI]

This is a problem and the feature itself has caused issues but it's not true that the feature is not used. Specifically Cairo 0 contract artifacts require this to function.

Can you show me a minimal example where this is happening though? I've never encountered this specific issue myself. Thanks!

[fracek]

I created a repro repo here. The issue only appears when serializing data with libraries that are not serde_json (in the repo serde_yaml, serde_toml, and serde_xml).

[fracek]

Another option is to put the cairo0 stuff behind a feature flag and only set the arbitrary precision flag in that case.

[fracek]

Thanks! Really appreciate this.