Flexible tree indent size #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yfuruyama
commented
Jul 13, 2020
| @@ -55,8 +55,8 @@ func TestLevel(t *testing.T) { | |||
| actual := tree.String() | |||
| expected := `. | |||
| ├── hello | |||
| │ ├── my friend | |||
There was a problem hiding this comment.
It looks like this had a non-breaking space character (\u00a0). I didn't tell the reason why the special character was used, so I changed to the normal space character.
If it was intentional to use the \u00a0, I will revert these changes.
There was a problem hiding this comment.
I was following tree utility output, but it's actually strange and unpredictable so let's fallback to normal spaces :)
|
@xlab Could you take a look? |
xlab
approved these changes
Jul 15, 2020
| @@ -55,8 +55,8 @@ func TestLevel(t *testing.T) { | |||
| actual := tree.String() | |||
| expected := `. | |||
| ├── hello | |||
| │ ├── my friend | |||
There was a problem hiding this comment.
I was following tree utility output, but it's actually strange and unpredictable so let's fallback to normal spaces :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed to allow users to configure tree indent size via
IndentSizevariable.This would be needed when we use a custom edge type like this.