Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check slice length for FindLastNode() to prevent panic #12

Merged
merged 1 commit into from
Jul 15, 2020
Merged

Check slice length for FindLastNode() to prevent panic #12

merged 1 commit into from
Jul 15, 2020

Conversation

yfuruyama
Copy link
Contributor

The program is paniced when FindlastNode() is called on the root node.
https://play.golang.org/p/DxiDN05mWQl

@yfuruyama
Copy link
Contributor Author

@xlab Could you take a look?

@xlab xlab merged commit 10e0bc3 into xlab:master Jul 15, 2020
@xlab
Copy link
Owner

xlab commented Jul 15, 2020

Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xlab xlab xlab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yfuruyama @xlab