bell fix #35
Merged
bell fix #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
removed old term_bell function. Tests ok for me. Reply here if good for you and Ill merge |
sblendorio
reviewed
Mar 26, 2019
| @@ -669,10 +669,28 @@ void uii_data_print(void) { | |||
| asm("cmp #$0a"); | |||
| asm("beq %g", skipline); | |||
| #endif | |||
| // check for bell character and perform sound if so | |||
| asm("cmp #$07"); | |||
There was a problem hiding this comment.
I would change lines 673..689 in:
asm("cmp #$07");
asm("bne %g", skipbell);
asm("jsr %v", term_bell)
skipbell:
asm("jsr $ffd2");
There was a problem hiding this comment.
We can also have conditional compiling, skipping term_bell on C128, since on C128 CHROUT of #7 char produces a bell sound
There was a problem hiding this comment.
...but maybe your code is quicker, since it's directly ASM. In that case, let's remove the former term_bell function.
|
we can avoid code duplication at all calling term_bell from within asm
*asm("jsr %v", term_bell)*
…On Tue, Mar 26, 2019 at 3:01 PM Scott Hutter ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/ultimateterm.c
<#35 (comment)>
:
> @@ -187,7 +186,9 @@ void term_displayheader(void) {
void putstring_ascii(char *str) {
for (; *str; str++)
- if (*str != LF) *str==BELL ? term_bell() : putchar(ascToPet[*str]);
+ if (*str != LF) {
yeah, youre right. Ive reverted the term_bell function for that purpose
for now. As bad as duplicated code is, its very small. And, we can use the
bell function for other things as well, such as connection notification or
termination notification.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#35 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACBUnQ4WjDzu6SBkq-Ir0Gy7Hwv6hpqsks5vaigvgaJpZM4cHHJ_>
.
--
Francesco Sblendorio
http://fsblendorio.blogspot.com
http://www.sblendorio.eu
|
|
makes sense - will do that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems that the terminal bell stop sounding. I implemented the bell in the assembly code, which seems to work fine now. Please test and confirm