Add Java 16 to CI build action and fix test on JDK 16+

xlate · Jun 19, 2021 · fbcb346 · fbcb346
1 parent 0769cdd
commit fbcb346
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 5 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -29,7 +29,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        java: [8, 11]
+        java: [8, 11, 16]
     name: Build with JDK ${{matrix.java}}
 
     steps:

diff --git a/src/test/java/io/xlate/edi/internal/stream/StaEDIXMLStreamReaderTest.java b/src/test/java/io/xlate/edi/internal/stream/StaEDIXMLStreamReaderTest.java
@@ -43,6 +43,7 @@
 import java.util.logging.Logger;
 
 import javax.xml.namespace.NamespaceContext;
+import javax.xml.stream.StreamFilter;
 import javax.xml.stream.XMLInputFactory;
 import javax.xml.stream.XMLStreamConstants;
 import javax.xml.stream.XMLStreamException;
@@ -76,6 +77,7 @@
 import io.xlate.edi.stream.EDIStreamValidationError;
 import io.xlate.edi.stream.EDIStreamWriter;
 import io.xlate.edi.stream.Location;
+import io.xlate.edi.test.StaEDITestUtil;
 
 @SuppressWarnings("resource")
 class StaEDIXMLStreamReaderTest {
@@ -903,11 +905,18 @@ void testInvalidInput() throws Exception {
         InputStream stream = new ByteArrayInputStream("{}".getBytes());
         ediReader = factory.createEDIStreamReader(stream);
         XMLStreamReader xmlReader = factory.createXMLStreamReader(ediReader);
-        XMLStreamReader filtered = XMLInputFactory.newFactory().createFilteredReader(xmlReader,
-                                                                                     reader -> reader.getEventType() == XMLStreamConstants.START_ELEMENT &&
-                                                                                               reader.getLocalName().equals("TRANSACTION"));
+        StreamFilter xmlFilter = reader -> reader.getEventType() == XMLStreamConstants.START_ELEMENT &&
+                reader.getLocalName().equals("TRANSACTION");
+        XMLStreamException thrown;
+
+        if (Integer.parseInt(StaEDITestUtil.getJavaVersion()[0]) >= 16) {
+            // See fix for JDK-8255918: https://github.com/openjdk/jdk/pull/1209
+            thrown = assertThrows(XMLStreamException.class, () -> XMLInputFactory.newFactory().createFilteredReader(xmlReader, xmlFilter));
+        } else {
+            XMLStreamReader filtered = XMLInputFactory.newFactory().createFilteredReader(xmlReader, xmlFilter);
+            thrown = assertThrows(XMLStreamException.class, () -> filtered.hasNext());
+        }
 
-        XMLStreamException thrown = assertThrows(XMLStreamException.class, () -> filtered.hasNext());
         assertTrue(thrown.getCause() instanceof EDIStreamException);
         String message = thrown.getCause().getMessage();
         assertTrue(message.contains("EDIE003"));

diff --git a/src/test/java/io/xlate/edi/test/StaEDITestUtil.java b/src/test/java/io/xlate/edi/test/StaEDITestUtil.java
@@ -50,4 +50,9 @@ public boolean accept(EDIStreamReader reader) {
         };
         return factory.createFilteredReader(reader, filter);
     }
+
+    public static String[] getJavaVersion() {
+        String versionString = System.getProperty("java.version");
+        return versionString.split("[\\._]");
+    }
 }