Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure this project follows Stencil best practices #3

Closed
manekinekko opened this issue Aug 23, 2019 · 3 comments · Fixed by #12
Closed

Make sure this project follows Stencil best practices #3

manekinekko opened this issue Aug 23, 2019 · 3 comments · Fixed by #12
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@manekinekko
Copy link
Member

No description provided.

@manekinekko manekinekko added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Aug 23, 2019
@Jefiozie
Copy link
Member

Jefiozie commented Nov 5, 2019

Hi @romulocintra, could you provide me some guidance on what the best practices are?
I can find some time to get this repo up to standards somewhere upcoming days, if you don't mind that I'm picking up this issue?

@romulocintra
Copy link
Member

Hi @Jefiozie happy that you taking over in reality no time at all... More than have best practices on composing the xlayers-lite we should have a look in the issues i opened few time ago... some of them were directly related with existing code back on August(lot of things changed since ) and the goal was to split implementation in blocks.

About best practices stencil is so so small that is difficult to have any huge anti-pattern but will be reviewing PR and you have ionic as a great reference.

@Jefiozie
Copy link
Member

Jefiozie commented Nov 7, 2019

Thanks @romulocintra I will look at ionic for now and add some extra linting rules to the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants