New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CodeGen: add Angular Element support #244
Comments
Finally I managed to get a closer look into xLayers 🙌 and took the chance to give this issue a try (although it might be a bit hard for a "good first issue" 💪 ). I started a local WIP-PR to keep track of my changes so far (don't be afraid of commit-format - will adjust when rebasing). I simply started to follow the existing structure to understand the architecture and some questions arose:
|
Thanks for your honest feedback🙏🏻, I can imagen that some parts of xLayers are hard to understand right away. I will provide some feedback on your comments and also cc: @manekinekko for his ideas around this issue.
I believe it would be nice if it is next to Angular.
I think it would be good to mention some of these points in the readme of the generated code. Do you agree on this?
I think we could go for a minimal setup with some explaining in the Readme. In the next iteration of this generator, we can have a look if we can expand by using specific bundle strategies or extra snippets. However, if you have a other option or think it would be better to apply this, be our guest 🙏🏻 I hope I provided you some extra info to get working on this issue. Let me know if you need some help or some extra information on the parts of the generator. We can help you with understanding some of the core parts. Also, I wanted to thank you for starting the discussion on this issue and having a look into this.🙏🏻 |
Add Angular Element code generation support. The solution tries to streamline the process described in `ngx-build-plus` by Manfred Steyer (https://github.com/manfredsteyer/ngx-build-plus). If you generate the assets with the editor and follow the README you will create a minimal toolchain to create Angular Elements in general. Closes xlayers#244
Add Angular Element code generation support. The solution tries to streamline the process described in `ngx-build-plus` by Manfred Steyer (https://github.com/manfredsteyer/ngx-build-plus). If you generate the assets with the editor and follow the README you will create a minimal toolchain to create Angular Elements in general. Closes xlayers#244
Add Angular Element code generation support. The solution tries to streamline the process described in `ngx-build-plus` by Manfred Steyer (https://github.com/manfredsteyer/ngx-build-plus). If you generate the assets with the editor and follow the README you will create a minimal toolchain to create Angular Elements in general. Closes xlayers#244
Add Angular Element code generation support. The solution tries to streamline the process described in `ngx-build-plus` by Manfred Steyer (https://github.com/manfredsteyer/ngx-build-plus). If you generate the assets with the editor and follow the README you will create a minimal toolchain to create Angular Elements in general. Closes #244
See docs: https://angular.io/guide/elements
The text was updated successfully, but these errors were encountered: