refactor: restructure the app folders/files #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
manekinekko
force-pushed
the
files-structure-refactoring
branch
16 times, most recently
from
b265470
to
98b5fec
Compare
manekinekko
force-pushed
the
files-structure-refactoring
branch
from
98b5fec
to
a816812
Compare
manekinekko
force-pushed
the
files-structure-refactoring
branch
from
8663358
to
8ba2b3c
Compare
…ers/xlayers into files-structure-refactoring
manekinekko
requested review from
Jefiozie and
shikanime
and removed request for
Jefiozie
manekinekko
requested review from
Jefiozie and
shikanime
and removed request for
shikanime
Jefiozie
approved these changes
Mar 14, 2019
shikanime
pushed a commit
to sfeir-open-source/xlayers
that referenced
this pull request
Mar 14, 2019
* refactor: restructure the app folders/files Fixes: xlayers#267 * fix: small fixes after restructure * fix: small fixes after restructure * fix: preload all lazymodules and use the store inside SketchService * fix: guard will redirect when no page selected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
/editor/previewor/editor/codewith no design loaded, it doesn’t redirect to/upload. Make sure theEditorGuardServicefires correctly.SketchServicedoesn't hold any internal state since now it is used in the lazy loaded module, hence we are not getting a singleton anymore.