Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: twitter card #269

Merged
merged 1 commit into from Mar 14, 2019
Merged

fix: twitter card #269

merged 1 commit into from Mar 14, 2019

Conversation

Jefiozie
Copy link
Member

@Jefiozie Jefiozie commented Mar 12, 2019 •
edited

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

manekinekko
manekinekko requested changes Mar 12, 2019
View reviewed changes
packages/xlayers/src/index.html Outdated Show resolved Hide resolved
@Jefiozie
Copy link
Member Author

Will fix the card problem :
image

image

@Jefiozie Jefiozie marked this pull request as ready for review March 12, 2019 14:16
@ghost ghost assigned Jefiozie Mar 12, 2019
@ghost ghost added the review label Mar 12, 2019
@Jefiozie Jefiozie force-pushed the FixTwitterCard branch 3 times, most recently from 80b835f to b099595 Compare March 13, 2019 07:13
@Jefiozie
Copy link
Member Author

Looks like something is changed and now netlify timedout:

'building site': Command did not finish within the time limit

@manekinekko manekinekko merged commit 347000c into xlayers:master Mar 14, 2019
@ghost ghost removed the review label Mar 14, 2019
shikanime pushed a commit to sfeir-open-source/xlayers that referenced this pull request Mar 14, 2019
@Jefiozie @shikanime
fix: twitter card (xlayers#269)
2e02697
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manekinekko manekinekko manekinekko approved these changes

Assignees

@Jefiozie Jefiozie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jefiozie @manekinekko