build: lint-staged replaced for pretty-quick/prettier #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
manekinekko
requested changes
Mar 18, 2019
package.json
Outdated
| @@ -110,6 +99,8 @@ | |||
| "karma-mocha-reporter": "^2.2.5", | |||
| "ng-packagr": "^4.7.1", | |||
| "npm-run-all": "^4.1.5", | |||
| "prettier": "^1.16.4", | |||
|
Why do we need to switch to prettier? |
|
Just to have a consequent styling of code. Removed it for now. |
manekinekko
approved these changes
Mar 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lint-staged is not working as expected with the
angular-clisee: lint-staged issueI think when this issue is resolved we can use it.
For now I implemented pretty-quick as a simple replacement.
Closes #280
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #280
What is the new behavior?
Does this PR introduce a breaking change?
Other information