Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enrich parser test #284

Merged
merged 7 commits into from Mar 25, 2019
Merged

Enrich parser test #284

merged 7 commits into from Mar 25, 2019

Conversation

shikanime
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the new behavior?

Fixing type and adding more test on sketch parser.

Does this PR introduce a breaking change?

  • Yes
  • No

@ghost ghost assigned shikanime Mar 20, 2019
@ghost ghost added the review label Mar 20, 2019
@shikanime shikanime changed the title Chore/enrich parser test Enrich parser test Mar 20, 2019
@shikanime shikanime marked this pull request as ready for review March 21, 2019 13:37
@manekinekko manekinekko merged commit 4e9a585 into xlayers:master Mar 25, 2019
@ghost ghost removed the review label Mar 25, 2019
t-dambacher added a commit to t-dambacher/xlayers that referenced this pull request Mar 25, 2019
@t-dambacher
Merge pull request #1 from xlayers/master
9a92e8d 
chore: enrich parser test (xlayers#284)
t-dambacher pushed a commit to t-dambacher/xlayers that referenced this pull request Apr 9, 2019
@shikanime
chore: enrich parser test (xlayers#284)
f068f27 
* test: refactor parser name

* chore: remove missed type todo

* test: add parse point test

* test: add parse set text test

* test: add set solid test

* test: reorder sketch parser test

* chore: update sketchapp type
@shikanime shikanime deleted the chore/enrich-parser-test branch April 16, 2019 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manekinekko manekinekko manekinekko approved these changes

Assignees

@shikanime shikanime

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shikanime @manekinekko