Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cypress tests #285

Merged
merged 14 commits into from Mar 26, 2019
Merged

Add cypress tests #285

merged 14 commits into from Mar 26, 2019

Conversation

krvajal
Copy link
Contributor

@krvajal krvajal commented Mar 21, 2019 •
edited

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe: Added Cypress tests

What is the current behavior?

Issue Number: #238

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@krvajal
Copy link
Contributor Author

krvajal commented Mar 21, 2019

This is just a starting point to gather some feedback. I will add more tests one the setup if correct.

@Jefiozie Jefiozie requested a review from shikanime March 21, 2019 10:05
@shikanime
Copy link
Member

shikanime commented Mar 21, 2019 •
edited

Hello @krvajal ,

Thank for you contribution ✨.

It seems that the CI tests fail because Jest is trying to run cypress e2e tests.

xlayers/jest.config.js

Line 3 in 5ce26ee

"<rootDir>/tests",

We should only includes "<rootDir>/tests/integration".

@krvajal
Copy link
Contributor Author

krvajal commented Mar 21, 2019

Not sure what this sentence means

We should only includes only "/tests/integration".

@shikanime
Copy link
Member

shikanime commented Mar 21, 2019 •
edited

I mean that we only have to include the /tests/integration folder for Jest instead of including the entire /tests folder in the jest.config.js

krvajal
krvajal commented Mar 21, 2019
View reviewed changes
jest.config.js Outdated Show resolved Hide resolved
@krvajal
Copy link
Contributor Author

krvajal commented Mar 21, 2019

@shikanime I have pushed a fix. Lets wait for the CI checks

@shikanime
Copy link
Member

shikanime commented Mar 21, 2019 •
edited

@krvajal For the moment, the CI only runs for unit and integration tests. The e2e tests have be added to the CI Circle configuration but I don't really know if Cypress needs some requirements to work on Circle CI 😕At a time we had some issue with it.

manekinekko
manekinekko requested changes Mar 21, 2019
View reviewed changes
package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
Jefiozie
Jefiozie reviewed Mar 21, 2019
View reviewed changes
package.json Outdated Show resolved Hide resolved
@krvajal
Copy link
Contributor Author

krvajal commented Mar 21, 2019

Hey guys, thanks for your feedback. I have addressed all the things you pointed out and made sure the tests are running and passing on CircleCI. So I think this is ready for a second review.

manekinekko
manekinekko requested changes Mar 21, 2019
View reviewed changes
package.json Show resolved Hide resolved
@manekinekko
Copy link
Member

manekinekko commented Mar 21, 2019 •
edited

Hi @krvajal thank you so much for this work. There is only one issue left (#285 (diff)) and we can merge this PR.

@ghost ghost assigned manekinekko Mar 26, 2019
@ghost ghost added the review label Mar 26, 2019
@manekinekko manekinekko merged commit e1c27de into xlayers:master Mar 26, 2019
@ghost ghost removed the review label Mar 26, 2019
t-dambacher pushed a commit to t-dambacher/xlayers that referenced this pull request Apr 9, 2019
@krvajal
test(e2e): add cypress test for landing page (xlayers#285)
aae005a 
* test(e2e): add cypress test for landing page

* chore(cypress): add scripts to run cypresss tests

* chore(tests): prevent Jest from running the e2e tests

* ci(e2e): add step to run e2e test on CircleCI

* chore(cypress): more cypress to dependencies

* chore: fix test:e2e run script

* chore: add cypress artifacts to the gitignore file

* chore: update caching strategy on the test job

* ci: update base image for the test job

* test: update home spec

* refactor: rename npm-scripts

* fix: add missing comma

* fix: rename e2e job on CI

* fix: rename cy.open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jefiozie Jefiozie Jefiozie left review comments

@manekinekko manekinekko manekinekko approved these changes

@shikanime shikanime Awaiting requested review from shikanime

Assignees

@manekinekko manekinekko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@krvajal @shikanime @manekinekko @Jefiozie