Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make the 3d design rotate #288

Merged
merged 1 commit into from Mar 26, 2019
Merged

feat: make the 3d design rotate #288

merged 1 commit into from Mar 26, 2019

Conversation

manekinekko
Copy link
Member

@manekinekko manekinekko commented Mar 21, 2019 •
edited

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #128

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@ghost ghost assigned manekinekko Mar 21, 2019
@ghost ghost added the review label Mar 21, 2019
Jefiozie
Jefiozie approved these changes Mar 24, 2019
View reviewed changes
Copy link
Member

@Jefiozie Jefiozie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could add a test for this rotation directive? To get some guarantees for the future?
Further I'm really happy with the behaviour great job!

@manekinekko manekinekko merged commit b433886 into master Mar 26, 2019
@ghost ghost removed the review label Mar 26, 2019
t-dambacher pushed a commit to t-dambacher/xlayers that referenced this pull request Apr 9, 2019
@manekinekko
feat: make the 3d design rotate (xlayers#288)
ab0ecc5 
Fixes xlayers#128
@manekinekko manekinekko deleted the 3d-rotation branch April 10, 2019 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jefiozie Jefiozie Jefiozie approved these changes

Assignees

@manekinekko manekinekko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@manekinekko @Jefiozie