Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(translate): add initial translate #305

Merged
merged 2 commits into from Jun 17, 2019

Conversation

Jefiozie
Copy link
Member

@Jefiozie Jefiozie commented Jun 5, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@Jefiozie Jefiozie force-pushed the feature/translations branch 3 times, most recently from da2fb35 to 7b8c28f Compare June 5, 2019 07:21
@Jefiozie Jefiozie marked this pull request as ready for review June 5, 2019 07:53
@Jefiozie Jefiozie requested a review from shikanime June 5, 2019 07:53
@manekinekko
Copy link
Member

@Jefiozie how can you change the language? I dont see any option in the UI.

@Jefiozie
Copy link
Member Author

Jefiozie commented Jun 5, 2019

I will implement this in an other PR if you agree on this? I was focussing on the basic setup.

At the moment it will look at browser language and switch to dutch.

@Jefiozie
Copy link
Member Author

Jefiozie commented Jun 8, 2019

Let's discuss the "switching language" in our sync meeting.

@manekinekko manekinekko merged commit 6cf45aa into xlayers:master Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants