Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(translations): translate pointer on landing pages #314

Merged

Conversation

sumitparakh
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Landing page screenshots are not translated as per browser landing. Please refer to the screenshot in the issue below

Issue Number: #311

What is the new behavior?

Translation added.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@sumitparakh sumitparakh marked this pull request as ready for review July 13, 2019 07:30
@sumitparakh
Copy link
Contributor Author

@Jefiozie I've used google translate so let me know if translations are correct or not

@Jefiozie
Copy link
Member

Thank you @sumitparakh, I will have a look at your PR in upcoming days and get back to you. 😃

Copy link
Member

@Jefiozie Jefiozie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sumitparakh, I think we are almost done, I did some small changes on the Dutch translations. Could you change these proposed translations?

After this, I believe we can approve it.

Thanks for your help 🙏🏻

src/assets/i18n/nl.json Outdated Show resolved Hide resolved
src/assets/i18n/nl.json Outdated Show resolved Hide resolved
src/assets/i18n/nl.json Outdated Show resolved Hide resolved
src/assets/i18n/nl.json Outdated Show resolved Hide resolved
src/assets/i18n/nl.json Outdated Show resolved Hide resolved
src/assets/i18n/nl.json Outdated Show resolved Hide resolved
src/assets/i18n/nl.json Outdated Show resolved Hide resolved
Copy link
Member

@manekinekko manekinekko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving this PR to unblock you but delegating the review to @Jefiozie

@sumitparakh
Copy link
Contributor Author

@Jefiozie all done.

@Jefiozie
Copy link
Member

LGTM

@Jefiozie Jefiozie merged commit 5079302 into xlayers:master Jul 15, 2019
@sumitparakh sumitparakh deleted the sumitparakh/translatePointers/311 branch July 15, 2019 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants