fix(parser): pdf parsing at first #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I fixed this issue because we should support the later version of sketch. |
manekinekko
approved these changes
Sep 15, 2019
|
@Jefiozie thanks for sending the PR. would you mind looking at the e2e tests? Interaction.spec.ts is failing. |
Change parsing pdf at first because of changes in sketch file Closes xlayers#321, xlayers#323
|
Hm, tests are fine after a re-run, maybe a glitch with cypress.? @manekinekko |
shikanime
pushed a commit
to sfeir-open-source/xlayers
that referenced
this pull request
Oct 7, 2019
Change parsing pdf at first because of changes in sketch file Closes xlayers#321, xlayers#323
manekinekko
pushed a commit
that referenced
this pull request
Oct 17, 2019
* chore: add vue experimental codegen (wip) * docs: Update README.md (#299) * fix(editor): icon was not visible for lit Elements (#300) The icon registered for lit-elements was defined as polymer. Renamed it to litElement. * feat(app): hightlight dropzone when dragging over it (#301) Closes 270 * chore: add blocgen base * chore: move new codegen to subfolder * chore: add css parser * chore: rename root folder * chore: add Parser options * chore: add initial vue blocgen * chore: add edge support for symbolmaster * chore: separate codegen from parser * chore: update vue readme * chore: add tag autoclosing on empty * fix: xml trailling space blank * refactor: simplify bitmap ressource format * fix: css classname property location * fix: remove autoclose and add undefined css guard * refactor: merge sketch style parser with blocgen * fix: orphelin tag * fix: configuration file not loaded * chore: switch to blocgen adapter * chore: conditionnal css output * chore: add rule to svg * chore: add text parser * chore: add frame default css * fix: join text array * chore: move css class definition to css parser service * refactor: explode blocgen service * chore: blocgen local reorganisation * refactor: separate blocgen from main code * refactor: separate vue compute and render * chore: remove useless vue import template * refactor: modernize preview * chore: add styling optimization * fix: css optimizer * fix: css shadow * fix: blocgen svg and css * fix: fill quote * chore: inline shapes and images * refactor: fix svg blocgen name * refactor: remove karma files * style: lint * refactor: arg order and remove options arg * chore: remove legacy blocgen * fix: std blocgen type import path * fix: libraries types * fix: lib import * fix: import path * fix: integration tests * fix: remove misssing lib.build.prod * ci: remove lib.build * refactor: remove meta editor config * chore: remove useless properties * fix: svg position * chore: remove misplaced files * refactor: remove inlined svg styles * refactor: facade blocgen and rename sketch ingestor * chore: merge layer and symbolMaster preview * refactor: clean useless previousLayout * chore: guard against nul currentData * fix: shape preview * refactor: remove old resource manager * chore: clarify std naming * chore: add symbol master in std * style: global lint * fix: missing page wireframe * test: modernize integration test * test: modernize e2e * fix: jest config * chore: remove useless sketch service test * fix: test type conflict * fix: explicit script fail * chore: remove conditionnal traversing * chore: add symbol master identifier util * chore: merge text and bitmap blocgens to stdlib * fix: symbol import * chore: rename resource service * fix: integration snapshot * chore: add flexible rendering options * chore: add Angular to blocgen * chore: add lit and react codegen * chore: web multi render integration * chore: standardize name * refactor: blocgen compute flow * chore: add layer tools * chore: change image dataurl to png * chore: optimize css parser scope * chore: image lookup return base64 by default * chore: svg fixed size * chore: optional svg options * fix: svg context always true * chore: remove get to put context * chore: remove useless angular import * chore: add xml namespace to web options * chore: remove useless format service from webblocgen * chore: ignore page layer from web * chore: add optional classname generation * chore: move angular routing template to service class * chore: reindent stackblitz sample files * chore: move stackblitz spec * chore: npm audit fix * fix: merge conflicts * fix: typescript transpiler conflict * chore: drop 50 and 51 version support * style: global lint * chore: bump circleci node version * chore: disable demo list for less than 51 * fix: lint warning * fix: svg flatmap * chore: remove old package * fix: cross app library dependency * fix: circular deps * fix: useless circular import * core: fix package references * chore: replace build by makefile * fix: layer tree layout wireframe * chore: remove deprecated rules * refactor: list join to template * chore: app build use makefile * chore: update webblocgen context parsing * fix: undefined stencil page * fix: webrender html to string * style: global lint * fix: e2e tests * fix: update test snapshot * fix: editorconfig makefile indent * chore: remove karma test * chore: revert vscode setting * chore: cleanup package css blocgen * refactor: rename currentfile to currentdata * refactor: rename sketchutil to sketchlib * refactor: rename tag to group * refactor: remove useless codecomponent oninit * fix: add traversing to default web render * style: lint web blocgen * chore: remove missplaced quote * fix: symbol tag * chore: improve template * chore: prestart hook * chore: add make to build command * chore: separate web parser from render * chore: improve code templating * fix: svg missing indent * revert: closure compiler annotate * fix: block instead of text tag * refactor: standardize code structure * fix: uninterpreted react css import * fix: missing oval * revert: remove div class on text * chore: xamarin svg compat bridge * chore: remove default context behavior * fix: templating * chore: comment integration example * fix: missing classname * fix: image export * fix: null context * chore: remove web type block * refactor: layer naming consistency * refactor: remove useless prividers * chore: add peer dependencies * chore: rename render * refactor: rename blocgen to codegen * refactor: move xamarin codegen * feat(landing-page): updated the landing page screenshots (#313) Updated the screenshots on the landing page and the pointers. Closes: #312 * fix(parser): pdf parsing at first (#324) Change parsing pdf at first because of changes in sketch file Closes #321, #323
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Pdf parsing is as second last.
Issue Number: #321, #323
What is the new behavior?
Change parsing pdf at first because of changes in sketch file
Does this PR introduce a breaking change?
Other information