Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: add tests #343

Merged
merged 18 commits into from Nov 30, 2019
Merged

tests: add tests #343

merged 18 commits into from Nov 30, 2019

Conversation

Jefiozie
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@Jefiozie Jefiozie marked this pull request as ready for review November 28, 2019 13:28
@Jefiozie
Copy link
Member Author

merging this so we have an working next.xlayers.dev

@Jefiozie Jefiozie changed the title test(sketch-lib): add initial tests tests: add tests Nov 30, 2019
@Jefiozie Jefiozie merged commit e388110 into xlayers:master Nov 30, 2019
@Jefiozie Jefiozie deleted the codegen-tests branch November 30, 2019 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumitparakh sumitparakh sumitparakh left review comments

@manekinekko manekinekko Awaiting requested review from manekinekko

@shikanime shikanime Awaiting requested review from shikanime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jefiozie @sumitparakh