Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: stamp version without rebuilding #390

Merged
merged 2 commits into from Nov 15, 2020

Conversation

Jefiozie
Copy link
Member

This PR will stamp our JS files without rebuilding the xlayers app.

@nx-cloud
Copy link

nx-cloud bot commented Oct 29, 2020

Nx Cloud Report

CI ran the following commands for commit e333d02. Click to see the status, the terminal output, and the build insights.

Status Command Start Time
#000000 nx affected:build --base=origin/main --head=HEAD --parallel --with-deps 11/15/2020, 3:54:47 PM
#000000 nx affected:lint --base=origin/main --head=HEAD --parallel 11/15/2020, 3:48:32 PM
#000000 nx affected:test --base=origin/main --head=HEAD --parallel --with-deps 11/15/2020, 3:48:35 PM

Sent with 💌 from NxCloud.

@manekinekko
Copy link
Member

@Jefiozie the stamping does not seem to be working.

image

@Jefiozie
Copy link
Member Author

Jefiozie commented Nov 2, 2020

Is this local with ng serve? If that is the case then it could be possible. At this moment we only support production bundles that are hosted via a webserver. If we would like to support the command ng serve we should make some changes.

@manekinekko
Copy link
Member

Actually I checked this on the Netlify preview URL: https://deploy-preview-390--xlayers.netlify.app/

@Jefiozie
Copy link
Member Author

Jefiozie commented Nov 3, 2020

What scripts do we run for netlify? Could you show/ tell me

@manekinekko
Copy link
Member

I think it's npm run build. So you can run the stamp process in a postbuild script

@Jefiozie
Copy link
Member Author

Jefiozie commented Nov 15, 2020

With the latest adjustments, this should be fixed for all of our builds that are run via: `npm run build, see also the netlify preview
image

@Jefiozie
Copy link
Member Author

@manekinekko, I think this one is done now and ready for review and merge.

@manekinekko manekinekko merged commit 8493fea into xlayers:main Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants