Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display uploaded file's version on mouseover in editor #391

Merged
merged 18 commits into from Dec 7, 2020

Conversation

anediaz
Copy link
Contributor

@anediaz anediaz commented Nov 7, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: 369

What is the new behavior?

When mouse over uploaded file's name in editor, we can see it's version

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Ane DIAZ DE TUESTA added 16 commits October 17, 2020 12:03
…e SketchFile type in SketchTypes and add needed methods to add file data in state when uploading a file
@nx-cloud
Copy link

nx-cloud bot commented Nov 14, 2020

Nx Cloud Report

CI ran the following commands for commit 8f6b5dc. Click to see the status, the terminal output, and the build insights.

Status Command Start Time
#000000 nx affected:build --base=origin/main --head=HEAD --parallel --with-deps 11/14/2020, 4:52:34 PM
#000000 nx affected:e2e --base=origin/main --head=HEAD --parallel --with-deps 11/14/2020, 4:49:52 PM
#000000 nx affected:lint --base=origin/main --head=HEAD --parallel 11/14/2020, 4:49:58 PM
#000000 nx affected:test --base=origin/main --head=HEAD --parallel --with-deps 11/14/2020, 4:49:47 PM

Sent with 💌 from NxCloud.

@anediaz
Copy link
Contributor Author

anediaz commented Dec 7, 2020

I forgot this PR.
I'm wondering why some tests fail, while in my computer everything seems OK.
I think the issue is related with the application's version that is used when running e2e tests.
I'd like to merge this PR before I forget it one second time, could you please help me?

@manekinekko
Copy link
Member

Thanks for the update @anediaz. I am going to review and merge this PR 👍

@manekinekko manekinekko merged commit 16dc93f into xlayers:main Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants