Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some convenience methods to JsonValue #19

Merged
merged 3 commits into from
Apr 13, 2021
Merged

Add some convenience methods to JsonValue #19

merged 3 commits into from
Apr 13, 2021

Conversation

KiChjang
Copy link
Contributor

Should be pretty self-explanatory. Added unit test to ensure they work as intended.

xlc
xlc reviewed Apr 12, 2021
View reviewed changes
Copy link
Owner

@xlc xlc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Happy with everything except to_xxx methods.

src/json.rs Outdated Show resolved Hide resolved
@KiChjang
Copy link
Contributor Author

@xlc Comments addressed.

xlc
xlc reviewed Apr 13, 2021
View reviewed changes
Copy link
Owner

@xlc xlc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more tests for the None case and should be good

@KiChjang KiChjang force-pushed the convenience-methods branch 2 times, most recently from b525a99 to ab1a2a8 Compare April 13, 2021 06:03
@KiChjang
Copy link
Contributor Author

@xlc Test cases added.

@xlc xlc merged commit 205846e into xlc:master Apr 13, 2021
@KiChjang KiChjang deleted the convenience-methods branch April 13, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xlc xlc xlc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KiChjang @xlc