Make everything configurable #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #145 +/- ##
==========================================
+ Coverage 65.60% 65.68% +0.08%
==========================================
Files 55 56 +1
Lines 8416 8979 +563
==========================================
+ Hits 5521 5898 +377
- Misses 2895 3081 +186
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Phoenix500526
force-pushed
the
make_everything_configurable
branch
7 times, most recently
from
ae95311
to
28999fe
Compare
Phoenix500526
requested review from
themanforfree,
rogercloud and
markcty
and removed request for
themanforfree and
rogercloud
markcty
suggested changes
Jan 13, 2023
Phoenix500526
force-pushed
the
make_everything_configurable
branch
from
28999fe
to
755213a
Compare
Phoenix500526
force-pushed
the
make_everything_configurable
branch
4 times, most recently
from
0234f6b
to
f7b1904
Compare
rogercloud
requested changes
Jan 16, 2023
Phoenix500526
force-pushed
the
make_everything_configurable
branch
from
f7b1904
to
25e3358
Compare
Phoenix500526
force-pushed
the
make_everything_configurable
branch
from
25e3358
to
bc92dfa
Compare
Phoenix500526
force-pushed
the
make_everything_configurable
branch
2 times, most recently
from
376464f
to
c9fe26f
Compare
1. add default values for ServerTimeout and ClientTimeout 2. using LevelFilter to replace LevelConfig 3. rename all field in RotationConfig 4. add ConfigParseError 5. refactor ClusterDuration and ClusterRange 6. move timeout out from state to a read-only shared variable 7. abstract a init_subscriber function
Phoenix500526
force-pushed
the
make_everything_configurable
branch
from
c9fe26f
to
a9a3160
Compare
themanforfree
approved these changes
Jan 17, 2023
rogercloud
approved these changes
Jan 17, 2023
markcty
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please briefly answer these questions:
Enable XlineServer to boot from a given configuration file, including log config, cluster config, auth config, trace config
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
Enables Xline server to boot from a configuration file, avoiding hard-coding some parameters, like
HEARTBEAT_INTERVAL([Curp] Make everything configurable #98 )what changes does this pull request make?
Add a config module in the util crate.
Change the init logic of XlineServer, CurpServer and CurpClient
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)
No