Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: client may send empty key to cluster #915

Open
lxl66566 opened this issue Jul 25, 2024 · 2 comments
Open

[BUG]: client may send empty key to cluster #915

lxl66566 opened this issue Jul 25, 2024 · 2 comments
Labels
bug Something isn't working Stale

Comments

@lxl66566
Copy link
Collaborator

lxl66566 commented Jul 25, 2024

currently xline client will not check if key is empty in requests like range() and delete() in crates/xline-client/src/clients/kv.rs, while etcd will check if key is empty before sending request.

although the with_prefix(), with_from_key() option could deal with empty key by push(0), but using with_range_end() will set a range_end without checking or modifying empty key. That could be a risk.

@lxl66566 lxl66566 added the bug Something isn't working label Jul 25, 2024
Copy link

👋 Thanks for opening this issue!

Reply with the following command on its own line to get help or engage:

  • /contributing-agreement : to print Contributing Agreements.
  • /assignme : to assign this issue to you.

Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the Stale label Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Stale
Projects
None yet
Development

No branches or pull requests

1 participant