Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactored pictures and added reports filters #1626

Merged
merged 19 commits into from Jun 24, 2021
Merged

refactored pictures and added reports filters #1626

merged 19 commits into from Jun 24, 2021

Conversation

fzumstein
Copy link
Member

@fzumstein fzumstein commented Jun 20, 2021 •
edited

  • use unique temp files for matplotlib/plotly (macOS pending)
  • allow to use svg file format
  • allow to choose the picture format with matplotlib/plotly
  • fix issues with wrong picture sizing
  • added picture.lock_aspect_ratio and app.cut_copy_mode
  • close matplotlib figure object properly
  • move plotly from pro to open source
  • added reports filters for DataFrame (noindex, noheader, sortasc, sortdesc, maxrows, aggsmall) and Pictures (format, scale, width, height)
  • removed empty line after h1 from Markdown default style

closes #1624
closes #1491
closes #1625
closes #1622
closes #1628

@fzumstein
refactored pictures:
2b7a9b3 
- use unique temp files for matplotlib/plotly
- allow to use svg file format
- use svg with matplotlib/plotly
- fix issues with wrong size
- added lock_aspect_ratio
- move plotly from pro to open source
closes #1624, closes #1491, closes #1625
@fzumstein fzumstein marked this pull request as draft June 21, 2021 06:37
@fzumstein fzumstein changed the title refactored pictures refactored pictures and reports filters Jun 22, 2021
@fzumstein fzumstein marked this pull request as ready for review June 23, 2021 16:25
@fzumstein fzumstein changed the title refactored pictures and reports filters refactored pictures and added reports filters Jun 24, 2021
@fzumstein fzumstein merged commit 07c496c into master Jun 24, 2021
@fzumstein fzumstein deleted the pictures-enhancements branch June 24, 2021 12:45
fzumstein added a commit that referenced this pull request Jun 25, 2021
@fzumstein
Filter fixes and additions (Part II of #1626) (#1632)
ef9cab2 
* filter fixes

* fix excel tables without headers

* handle no header dfs outside of Excel tables & fix aggsum/maxrows tests

* added "body" filter for dataframes

* docs [skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@fzumstein