Skip to content

Commit

Permalink
improve autoconf
Browse files Browse the repository at this point in the history
  • Loading branch information
@waruqi
waruqi committed Apr 28, 2024
1 parent 650ae53 commit 61498e2
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion xmake/modules/package/tools/autoconf.lua
View file
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,8 @@ function buildenvs(package, opt)
envs.LDFLAGS = table.concat(_translate_paths(ldflags), ' ')
end
if shflags then
envs.SHFLAGS = table.concat(_translate_paths(shflags), ' ')
-- autoconf does not use SHFLAGS
envs.LDFLAGS = table.concat(_translate_paths(shflags), ' ')
end

-- cross-compilation? pass the full build environments
Expand Down

3 comments on commit 61498e2

@SirLynix
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If both ldflags and shflags are set, shouldn't they be concat?

@waruqi
Copy link
Member Author

@waruqi waruqi commented on 61498e2 Apr 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right

@waruqi
Copy link
Member Author

@waruqi waruqi commented on 61498e2 Apr 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Please sign in to comment.