Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a add_assets to the vs generator #2384

Closed
TNtube opened this issue May 26, 2022 · 8 comments
Closed

Add a add_assets to the vs generator #2384

TNtube opened this issue May 26, 2022 · 8 comments

Comments

@TNtube
Copy link

TNtube commented May 26, 2022

Is your feature request related to a problem? Please describe.

I faced a problem with the current vs solution generator, I couldn't see my assets folder (contening mainly images and glsl scripts)

Describe the solution you'd like

A add_assets function (or any name that sound better) to add any non project files in the VS solution hierarchy.

Describe alternatives you've considered

I'm currently using add_headerfiles, that is working in my case but feel more like a hack than anything.

Thanks you

Additional context

No response

@SirLynix
Copy link
Member

Maybe we could reuse add_installfiles to include them in VS projects?

@waruqi
Copy link
Member

waruqi commented May 26, 2022

try add_headerfiles("xxx.glsl")?

@TNtube
Copy link
Author

TNtube commented May 26, 2022

That's currently what i'm doing and it works well, but I thought it was more a hack than a solution.

@Arthapz
Copy link
Member

Arthapz commented May 31, 2022

meson has "extra_files" to list them

@waruqi
Copy link
Member

waruqi commented May 31, 2022

meson is just a project generator, so it can provide various special interfaces related to the project generator.

But project generator is only an optional plug-in for xmake, and I don't want to add a special api just for the features that project generator needs.

@waruqi
Copy link
Member

waruqi commented Apr 10, 2023

May be we can add add_extrafiles for extra files. It will be used to support some of the following features.

  1. Only show them in vs/vsxmake project generator, but they will be not installed.
  2. ...

Only one case I can think of at the moment, but it's not enough to add an new api just for the vs project generator.

@waruqi
Copy link
Member

waruqi commented Aug 21, 2023

I have added it. add_extrafiles("*.txt") #4104

xmake update -s dev

@SirLynix
Copy link
Member

Awesome, thank you!

@waruqi waruqi added this to the v2.8.2 milestone Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants