Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add_cxflags broken during CMakeLists generate #3669

Closed
MaxwellGengYF opened this issue Apr 23, 2023 · 1 comment
Closed

add_cxflags broken during CMakeLists generate #3669

MaxwellGengYF opened this issue Apr 23, 2023 · 1 comment
Labels
bug
Milestone
v2.7.9

Comments

@MaxwellGengYF
Copy link
Contributor

Xmake Version

2.7.8

Operating System Version and Architecture

Any platform

Describe Bug

in on_load():

target:add("cxflags", "/Zc:preprocessor", {
tools = "cl"
});

"/Zc:preprocessor" will still be added to CMakeLists.txt even when target is using llvm-toolchain.

Expected Behavior

Such flags should not be added.

Project Configuration

No response

Additional Information and Error Logs

No response
waruqi added a commit that referenced this issue Apr 24, 2023
@waruqi
support tool flags #3669
cd4f63c
@waruqi waruqi mentioned this issue Apr 24, 2023
Merged
@waruqi
Copy link
Member

waruqi commented Apr 24, 2023

#3665 这个 patch 里，我支持上了，顺带正好帮我测下其他的改动是否会影响现有工程。。

xmake update -s github:xmake-io/xmake#cmakelists

@waruqi waruqi added this to the v2.7.9 milestone Apr 24, 2023
@waruqi waruqi closed this as completed Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v2.7.9
Development

No branches or pull requests
2 participants
@waruqi @MaxwellGengYF