-
-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tests for install & uninstall #115
Changes from 24 commits
c536607
9e014f7
f2e0d82
550e0a9
36a48f2
eca531f
3ddda43
7e750ae
31a7bbe
89e2cc7
962b99c
f1e3e37
a00ed18
7ee82c2
4fafe79
b91fc2f
a647f87
0744b67
578211e
1f93705
c55e08a
6f37771
33826d1
64e1e79
bbed6a5
abb1d57
ff1ba70
67a5ad7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -61,15 +61,17 @@ install: | |
@# install the xmake directory | ||
@cp -r xmake/* $(xmake_dir_install) | ||
@# make the xmake loader | ||
ifneq ($(PLAT),linux) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's this? Although we can get the executable path on linux, macOS and windows now. But maybe we cannot get it successfully on some linux distributions. So I think we still need |
||
@echo '#!/bin/bash' > $(xmake_loader) | ||
@echo 'export XMAKE_PROGRAM_DIR=$(xmake_dir_install)' >> $(xmake_loader) | ||
@echo '$(xmake_core_install) $(verbose) "$$@"' >> $(xmake_loader) | ||
else | ||
@ln -s '$(xmake_core_install)' '$(xmake_loader)' | ||
endif | ||
@# install the xmake loader | ||
@if [ ! -d $(prefix)/bin ]; then mkdir -p $(prefix)/bin; fi | ||
@mv $(xmake_loader) $(xmake_loader_install) | ||
@chmod 777 $(xmake_loader_install) | ||
@# tip | ||
@$(if $(findstring $(prefix)/bin,$(PATH)),,echo 'please export PATH=$$PATH:$(prefix)/bin') | ||
@# remove xmake.out | ||
@if [ -f '/tmp/xmake.out' ]; then rm /tmp/xmake.out; fi | ||
@# ok | ||
|
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's necessary to write the following code three times.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can use this implementation in dev to replace it directly. 😸