Support Nim Language #1759
Merged
Support Nim Language #1759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ghost
reviewed
Oct 21, 2021
| local maps = | ||
| { | ||
| none = "--opt:none" | ||
| , fast = "--opt:speed" |
There was a problem hiding this comment.
Hello, fast, faster and fastest should be -d:release by default because it also enables/disables other stuff, opt:speed by itself is not enough
There was a problem hiding this comment.
I have improved it. thanks!
ghost
reviewed
Oct 21, 2021
| , faster = "--opt:speed" | ||
| , fastest = "--opt:speed" | ||
| , smallest = "--opt:size" | ||
| , aggressive = "--opt:speed" |
There was a problem hiding this comment.
This should be -d:danger I think, it's like -d:release but it also disables all runtime checks which makes sense for an aggressive build
There was a problem hiding this comment.
ok, I will improve it. thanks.
ghost
reviewed
Oct 21, 2021
| , fast = "--opt:speed" | ||
| , faster = "--opt:speed" | ||
| , fastest = "--opt:speed" | ||
| , smallest = "--opt:size" |
There was a problem hiding this comment.
This should be -d:release --opt:size too, because -d: release coupled with opt:size is more effective than just opt:size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1756