Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve rule to support dependence order #2817

Merged
merged 15 commits into from
Sep 15, 2022
Merged

Improve rule to support dependence order #2817

merged 15 commits into from
Sep 15, 2022

Conversation

waruqi
Copy link
Member

@waruqi waruqi commented Sep 14, 2022

@waruqi waruqi marked this pull request as ready for review September 15, 2022 04:25
@waruqi
Copy link
Member Author

waruqi commented Sep 15, 2022

@xq114 @Arthapz @SirLynix

I have adjusted the script execution logic for the internal rules and I am not sure if it will break the existing project. But in theory it shouldn't affect existing projects, it should be consistent with the previous behaviour.

But for the better stability, I would also like your help to test together if it affects your own projects.

xmake update github:xmake-io/xmake#rule

@waruqi waruqi added this to the v2.7.2 milestone Sep 15, 2022
@SirLynix
Copy link
Member

Seems to works fine on my projects!

@waruqi
Copy link
Member Author

waruqi commented Sep 15, 2022

ok, thanks.

@waruqi waruqi merged commit f55c0a7 into dev Sep 15, 2022
@waruqi waruqi deleted the rule branch September 15, 2022 11:05
@Arthapz
Copy link
Member

Arthapz commented Sep 15, 2022

Work fine too on my side

@waruqi
Copy link
Member Author

waruqi commented Sep 15, 2022

Work fine too on my side

thanks

@xq114
Copy link
Contributor

xq114 commented Sep 16, 2022

Good on my side too

@waruqi
Copy link
Member Author

waruqi commented Sep 16, 2022

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants