Fix detection of target language for qt projects #3317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stray change in 02fb7ef broke it such that language set via `set_languages()` wasn't detected and `-std=c++11` was appended after `-std` flag that came from `set_languages()` in `xmake.lua`. To reproduce: 1. `xmake create -tqt.quickapp` 2. `vim xmake.lua` and add `set_languages("c++17")` 3. `xmake --verbose` and look at `-std=` options
waruqi
reviewed
Jan 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stray change in 02fb7ef broke it such that language set via
set_languages()wasn't detected and-std=c++11was appended after-stdflag that came fromset_languages()inxmake.lua.To reproduce:
xmake create -tqt.quickappvim xmake.luaand addset_languages("c++17")xmake --verboseand look at-std=options