export qt app for wasm #4373 #4138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
da-liii
reviewed
Sep 8, 2023
| table.insert(target:objectfiles(), filepath) | ||
| -- these files are located at lib/objects-Release/xxxmodule_resources_x/.rcc/xxxmodule.cpp.o | ||
| for _, framework in ipairs(qt_frameworks) do | ||
| if framework:startswith("Qt") then |
There was a problem hiding this comment.
QWasmIntegrationPlugin 不是以 Qt 开头的，所以这里的逻辑有问题，在我的pr里面修复了
There was a problem hiding this comment.
你那个 pr 里，我也没看到相关修复么。。而且我 merge 了你的 pr ，这个 pr 怎么也被 merge 了 。。我好像不记得 merge 它，怪了。。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4137