Skip root user check on Haiku OS

[cmeerw]

Haiku OS doesn't have any non-root users, so it doesn't make sense to warn about running as the root user.

[waruqi]

why?

[waruqi]

Haiku OS doesn't have any non-root users, so it doesn't make sense to warn about running as the root user.

so you should improve os.isroot() to support for haiku.

[SirLynix]

What if some code errors if os.isroot() returns false on haiku later? for example if we check root privileges before installing to /usr

[cmeerw]

Haiku OS doesn't have any non-root users, so it doesn't make sense to warn about running as the root user.

so you should improve os.isroot() to support for haiku.

I am not convinced that changing isroot is preferable.

Currently, code checks os.isroot() to ask the question "Do I have the privileges to make system-wide changes?" (in several install_package.lua) On Haiku OS the answer to that question should be "yes", so I'd think os.isroot() should return true on Haiku OS. On the other hand, there is no non-root user on Haiku OS, so warning about running as root doesn't seem helpful.

I am just worried, that trying to return false for os.isroot() on Haiku OS will actually cause more maintenance issues in the future as basically all those os.isroot() calls will need special handling on Haiku OS.

[waruqi]

well.